Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing parse-time deprecation warnings for imported modules #1072

Closed
hanche opened this issue Jul 13, 2020 · 3 comments
Closed

Missing parse-time deprecation warnings for imported modules #1072

hanche opened this issue Jul 13, 2020 · 3 comments
Milestone
0.15.0

Comments

@hanche
Copy link
Contributor

hanche commented Jul 13, 2020

When a file uses a trailing backslash for continuation in a file and that file is executed via -take or use, no deprecation warning occurs, even if the shell was run with -show-deprecations. The warning is shown in interactive use, however.
@xiaq xiaq added this to the 0.15.0 milestone Jul 14, 2020
@xiaq
Copy link
Member

xiaq commented Jul 14, 2020

In fact all the compile-time deprecation warnings are missing too...

@xiaq xiaq changed the title Missing deprecation warnings for backslash as continuation character Missing parse- and compile-time deprecation warnings for imported modules Jul 14, 2020
@xiaq xiaq changed the title Missing parse- and compile-time deprecation warnings for imported modules Missing parse-time deprecation warnings for imported modules Jul 14, 2020
@xiaq
Copy link
Member

xiaq commented Jul 14, 2020

Scratch that; compile-time deprecation still work. The original title was correct...

@xiaq xiaq closed this as completed in e5e0446 Jul 14, 2020
xiaq added a commit that referenced this issue Jul 14, 2020
@xiaq
Warn about deprecated syntax features in imported modules.
3d3cda4 
This fixes #1072.
@xiaq
Copy link
Member

xiaq commented Jul 14, 2020

The fix is cherry-picked onto the v0.14-release branch and will appear in the bugfix release v0.14.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
2 participants
@hanche @xiaq