New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document and normalize handling of symbolic UI key names #1163
Comments
Note that point three above applies to both the Honestly, I have very mixed feelings about the case-insensitive matching. It is "friendly". It also enables obfuscation. It could even be a security hole. Consider Unicode letter aliasing to mislead readers of a URL (or other text). I'm leaning towards making matching a modifier prefix case-sensitive. That is, you have to write |
I'm in support of case sensitivity, if only for aesthetic reasons. So long as documentation for bindings lists the proper form of The Alt key is typically represented by an The aforementioned software does not even understand |
Case insensitivity and short modifier names are useful when typing out key names in the CLI, and that's likely the only place it's useful. If there is a mode to insert the name of a key in the CLI - say pressing Ctrl-L inserts |
Converting literal key sequences to the symbolic name would be cool and useful. The fish shell ships with I am equally happy with making the key name case insensitive and documenting the behavior. This is simply about consistency and documenting behavior. P.S., This is an example of the fish_key_reader behavior where I pressed Alt-K:
|
/facepalm on my part since I just realized that the reason the key modifier can be case-insensitive but the key cannot (at least by default) is because we need to distinguish between letters such as |
Document the format of key names. Make function key name matching case-insensitive for consistency with how key modifers (e.g., "Alt") are handled. Resolves elves#1163
Document the format key of names and modifiers; albeit with a TODO regarding the `Shift` modifier. Make function key modifier matching case sensitive (`Alt` not `alt`) to match key name matching (`Enter` not `enter`). Implement `Ctrl-?` as the logical counterpart to `"\c?"`. Resolves elves#1163
Document the format key of names and modifiers; albeit with a TODO regarding the `Shift` modifier. Make function key modifier matching case sensitive (`Alt` not `alt`) to match key name matching (`Enter` not `enter`). Implement `Ctrl-?` as the logical counterpart to `"\c?"`. Resolves #1163
While looking into issue #912 I noticed three aspect of symbolic UI key names that needs some discussion. Here I'm talking about a binding map assignment in a statement such as
edit:insert:binding[Alt-Left] = { echo alt-left >/dev/tty }
.Alt-
,alt-
,aLt-
, etc.*) I think this behavior is desirable and should be retained. It also needs to be documented but non-canonical letter-case should be discouraged.
a-
(orA-
) instead ofAlt-
.*) Whether these shortened aliases should be retained is an open question. When I proposed allowing
[d]
or[type:d]
as shorter forms of the[type:dir]
wildcard modifier @xiaq rejected adding those aliases. It seems like the symbolic key names should also, if we're going to be consistent, not allow single letter modifiers; i.e.,A-
should not be an alias forAlt-
.Left
is okay whileleft
is not.*) I think the behavior should be modified to perform case insensitive matching of those names.
The text was updated successfully, but these errors were encountered: