Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement path:join #1562

Closed
krader1961 opened this issue Jun 24, 2022 · 0 comments · Fixed by #1563
Closed

Implement path:join #1562

krader1961 opened this issue Jun 24, 2022 · 0 comments · Fixed by #1563

Comments

@krader1961
Copy link
Contributor

I was working on adding unit tests for my fix for issue #1385 and realized that the test would benefit from a path:join command to accommodate the fact that on UNIX forward slash is used and on Windows backslash is used to separate path components. I worked around that shortcoming by using the equivalent Go function plus string concatenation to construct the test case. Nonetheless, it should be possible for Elvish programs to construct paths using native conventions for separating path components rather than assuming a forward slash works on every platform.

krader1961 added a commit to krader1961/elvish that referenced this issue Jun 25, 2022
krader1961 added a commit to krader1961/elvish that referenced this issue Jun 25, 2022
krader1961 added a commit to krader1961/elvish that referenced this issue Jul 20, 2022
xiaq pushed a commit that referenced this issue Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant